feat: factory for generic sync.Pool usage, with safety test mode - #215
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 92.54% 92.25% -0.29%
==========================================
Files 54 57 +3
Lines 2603 2816 +213
==========================================
+ Hits 2409 2598 +189
- Misses 148 165 +17
- Partials 46 53 +7 ☔ View full report in Codecov by Harness. |
This PR introduces a new utility module to manipulate sync.Pools more easily. It introduces generic wrapper to create pools of any type more concisely. There is a "RedeemablePool" wrapper to keep the "return to pool" closure readily available without needing further allocations (use-case: defer redeem()). A "SlicePool" allows to manipulate pools of slices more easily, and better control their growth / reuse of reallocated slices. Additional safeties are built in that fail early on typical pool errors (e.g. redeem a pointer that has not been borrowed). A "poolsdebug" build tag enables pool instrumentation to run tests with more assertions about the correct usage of pools (panics if a wrong pattern is detected). Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist