Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.11.0 #973

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Release v1.11.0 #973

merged 4 commits into from
Jan 23, 2025

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Jan 23, 2025

  1. I think this should be v1.10.1. Or should it be v1.11.0 ?

  2. I used this to create the changelog and then added author links manually

$ git log --oneline v1.10.0..HEAD | cut -c9- | sed -E -e 's/^/* /' -e 's%\(#(.*)\)%[#\1](https://github.com/go-mysql-org/go-mysql/pull/\1)%'
* mysql: Fix GetInt() with negative text result [#972](https://github.com/go-mysql-org/go-mysql/pull/972)
* client: Update docs [#970](https://github.com/go-mysql-org/go-mysql/pull/970)
* Cleanup: remove clear_vendor.sh [#971](https://github.com/go-mysql-org/go-mysql/pull/971)
* *: don't use zero value of mysql.Result [#969](https://github.com/go-mysql-org/go-mysql/pull/969)
* mysql: Fix ColumnNumber() panic with nil Resultset [#968](https://github.com/go-mysql-org/go-mysql/pull/968)
* replication: Improve COM_REGISTER_SLAVE [#967](https://github.com/go-mysql-org/go-mysql/pull/967)
* use syscall.Gettimeofday to get current time [#961](https://github.com/go-mysql-org/go-mysql/pull/961)
* Remove duplicate SIGINT in signal handling [#962](https://github.com/go-mysql-org/go-mysql/pull/962)
* feat: Added `time.Time` support for datetime format [#957](https://github.com/go-mysql-org/go-mysql/pull/957)
* mysql field: expose API to modify field vale [#960](https://github.com/go-mysql-org/go-mysql/pull/960)
* replication: Support GTID tag in PreviousGTIDsEvent [#952](https://github.com/go-mysql-org/go-mysql/pull/952)
* zeroalloc: don't use unsafe.Pointer [#959](https://github.com/go-mysql-org/go-mysql/pull/959)
* driver: allow configuration of the driver name [#958](https://github.com/go-mysql-org/go-mysql/pull/958)
* Update README [#950](https://github.com/go-mysql-org/go-mysql/pull/950)
* README: fix example for database/sql [#955](https://github.com/go-mysql-org/go-mysql/pull/955)
* CI: Update Go, MySQL and Ubuntu versions [#954](https://github.com/go-mysql-org/go-mysql/pull/954)
* canal,dump: Improve logging [#953](https://github.com/go-mysql-org/go-mysql/pull/953)
  1. I assume we create the tag after this is merged? Anything else I need to do?

@lance6716
Copy link
Collaborator

  1. I think the next version can be v1.11.0. Currently the patch version is only increased when I did something wrong on x.y.0 and release a new version without many changes
  2. I used gh CLI https://github.com/cli/cli to get author names, but I don't remember how to do that. Every time I use chatGPT's help 😂
  3. Yes the only thing to be done is push the git tag after this PR

Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: lance6716 <[email protected]>
@atercattus
Copy link
Member

atercattus commented Jan 23, 2025

I used a self-written cli to generate the changelog, but it works so-so. I would be glad if we switched or discussed switching to GH releases themselves.

If you need, here's what the utility generates now:

go-mysql-org/go-mysql$ ./changeloger --github-token=ghp_XXX
### Tag NEW_TAG_HERE (2025-01-23)
* Mysql: Fix GetInt() with negative NEWDECIMAL result. [#972](https://github.com/go-mysql-org/go-mysql/pull/972) ([dveeden](https://github.com/dveeden))
* Client: Update docs. [#970](https://github.com/go-mysql-org/go-mysql/pull/970) ([dveeden](https://github.com/dveeden))
* Cleanup: remove clear_vendor.sh. [#971](https://github.com/go-mysql-org/go-mysql/pull/971) ([dveeden](https://github.com/dveeden))
* *: don't use zero value of mysql.Result. [#969](https://github.com/go-mysql-org/go-mysql/pull/969) ([lance6716](https://github.com/lance6716))
* Mysql: Fix ColumnNumber() panic with nil Resultset. [#968](https://github.com/go-mysql-org/go-mysql/pull/968) ([dveeden](https://github.com/dveeden))
* Replication: Improve COM_REGISTER_SLAVE. [#967](https://github.com/go-mysql-org/go-mysql/pull/967) ([dveeden](https://github.com/dveeden))
* Use syscall.Gettimeofday to get current time. [#961](https://github.com/go-mysql-org/go-mysql/pull/961) ([hjweddie](https://github.com/hjweddie))
* Remove duplicate SIGINT in signal handling. [#962](https://github.com/go-mysql-org/go-mysql/pull/962) ([soya111](https://github.com/soya111))
* Feat: Added `time.Time` support for datetime format. [#957](https://github.com/go-mysql-org/go-mysql/pull/957) ([inoth](https://github.com/inoth))
* Mysql field: expose API to modify field value. [#960](https://github.com/go-mysql-org/go-mysql/pull/960) ([walkline](https://github.com/walkline))
* Replication: Support GTID tag in PreviousGTIDsEvent. [#952](https://github.com/go-mysql-org/go-mysql/pull/952) ([dveeden](https://github.com/dveeden))
* Zeroalloc: don't use unsafe.Pointer. [#959](https://github.com/go-mysql-org/go-mysql/pull/959) ([serprex](https://github.com/serprex))
* Driver: allow configuration of the driver name. [#958](https://github.com/go-mysql-org/go-mysql/pull/958) ([dveeden](https://github.com/dveeden))
* Update README. [#950](https://github.com/go-mysql-org/go-mysql/pull/950) ([dveeden](https://github.com/dveeden))
* README: fix example for database/sql. [#955](https://github.com/go-mysql-org/go-mysql/pull/955) ([dveeden](https://github.com/dveeden))
* CI: Update Go, MySQL and Ubuntu versions. [#954](https://github.com/go-mysql-org/go-mysql/pull/954) ([dveeden](https://github.com/dveeden))
* Canal,dump: Improve logging. [#953](https://github.com/go-mysql-org/go-mysql/pull/953) ([dveeden](https://github.com/dveeden))

* New release v1.10.0. ...
* ...

Copy link
Member

@atercattus atercattus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we have the last version here, but this is only docs.

@dveeden
Copy link
Collaborator Author

dveeden commented Jan 23, 2025

The only issue I see with gh release create v1.2.3 --generate-notes ... etc. is that it doesn't really match the PR workflow of first merging the changelog and then pushing the tag.

@dveeden
Copy link
Collaborator Author

dveeden commented Jan 23, 2025

Also, we have the last version here, but this is only docs.

Thanks. Fixed with a98f973

@dveeden
Copy link
Collaborator Author

dveeden commented Jan 23, 2025

I used a self-written cli to generate the changelog, but it works so-so. I would be glad if we switched or discussed switching to GH releases themselves.

If you need, here's what the utility generates now:

go-mysql-org/go-mysql$ ./changeloger --github-token=ghp_XXX
### Tag NEW_TAG_HERE (2025-01-23)
* Mysql: Fix GetInt() with negative NEWDECIMAL result. [#972](https://github.com/go-mysql-org/go-mysql/pull/972) ([dveeden](https://github.com/dveeden))
* Client: Update docs. [#970](https://github.com/go-mysql-org/go-mysql/pull/970) ([dveeden](https://github.com/dveeden))
* Cleanup: remove clear_vendor.sh. [#971](https://github.com/go-mysql-org/go-mysql/pull/971) ([dveeden](https://github.com/dveeden))
* *: don't use zero value of mysql.Result. [#969](https://github.com/go-mysql-org/go-mysql/pull/969) ([lance6716](https://github.com/lance6716))
* Mysql: Fix ColumnNumber() panic with nil Resultset. [#968](https://github.com/go-mysql-org/go-mysql/pull/968) ([dveeden](https://github.com/dveeden))
* Replication: Improve COM_REGISTER_SLAVE. [#967](https://github.com/go-mysql-org/go-mysql/pull/967) ([dveeden](https://github.com/dveeden))
* Use syscall.Gettimeofday to get current time. [#961](https://github.com/go-mysql-org/go-mysql/pull/961) ([hjweddie](https://github.com/hjweddie))
* Remove duplicate SIGINT in signal handling. [#962](https://github.com/go-mysql-org/go-mysql/pull/962) ([soya111](https://github.com/soya111))
* Feat: Added `time.Time` support for datetime format. [#957](https://github.com/go-mysql-org/go-mysql/pull/957) ([inoth](https://github.com/inoth))
* Mysql field: expose API to modify field value. [#960](https://github.com/go-mysql-org/go-mysql/pull/960) ([walkline](https://github.com/walkline))
* Replication: Support GTID tag in PreviousGTIDsEvent. [#952](https://github.com/go-mysql-org/go-mysql/pull/952) ([dveeden](https://github.com/dveeden))
* Zeroalloc: don't use unsafe.Pointer. [#959](https://github.com/go-mysql-org/go-mysql/pull/959) ([serprex](https://github.com/serprex))
* Driver: allow configuration of the driver name. [#958](https://github.com/go-mysql-org/go-mysql/pull/958) ([dveeden](https://github.com/dveeden))
* Update README. [#950](https://github.com/go-mysql-org/go-mysql/pull/950) ([dveeden](https://github.com/dveeden))
* README: fix example for database/sql. [#955](https://github.com/go-mysql-org/go-mysql/pull/955) ([dveeden](https://github.com/dveeden))
* CI: Update Go, MySQL and Ubuntu versions. [#954](https://github.com/go-mysql-org/go-mysql/pull/954) ([dveeden](https://github.com/dveeden))
* Canal,dump: Improve logging. [#953](https://github.com/go-mysql-org/go-mysql/pull/953) ([dveeden](https://github.com/dveeden))

* New release v1.10.0. ...
* ...

I've update CHANGELOG.md to use that.

The differences with my code are:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a32677c..6877f4c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,21 +1,21 @@
## Tag v1.11.0 (2025-01-23)
* [-mysql:-]{+Mysql:+} Fix GetInt() with negative [-text result-]{+NEWDECIMAL result.+} [#972](https://github.com/go-mysql-org/go-mysql/pull/972) ([dveeden](https://github.com/dveeden))
* [-client:-]{+Client:+} Update [-docs-]{+docs.+} [#970](https://github.com/go-mysql-org/go-mysql/pull/970) ([dveeden](https://github.com/dveeden))
* Cleanup: remove [-clear_vendor.sh-]{+clear_vendor.sh.+} [#971](https://github.com/go-mysql-org/go-mysql/pull/971) ([dveeden](https://github.com/dveeden))
* [-`*`:-]{+*:+} don't use zero value of [-mysql.Result-]{+mysql.Result.+} [#969](https://github.com/go-mysql-org/go-mysql/pull/969) ([lance6716](https://github.com/lance6716))
* [-mysql:-]{+Mysql:+} Fix ColumnNumber() panic with nil [-Resultset-]{+Resultset.+} [#968](https://github.com/go-mysql-org/go-mysql/pull/968) ([dveeden](https://github.com/dveeden))
* [-replication:-]{+Replication:+} Improve [-COM_REGISTER_SLAVE-]{+COM_REGISTER_SLAVE.+} [#967](https://github.com/go-mysql-org/go-mysql/pull/967) ([dveeden](https://github.com/dveeden))
* [-use-]{+Use+} syscall.Gettimeofday to get current [-time-]{+time.+} [#961](https://github.com/go-mysql-org/go-mysql/pull/961) ([hjweddie](https://github.com/hjweddie))
* Remove duplicate SIGINT in signal [-handling-]{+handling.+} [#962](https://github.com/go-mysql-org/go-mysql/pull/962) ([soya111](https://github.com/soya111))
* [-feat:-]{+Feat:+} Added `time.Time` support for datetime [-format-]{+format.+} [#957](https://github.com/go-mysql-org/go-mysql/pull/957) ([inoth](https://github.com/inoth))
* [-mysql-]{+Mysql+} field: expose API to modify field [-vale-]{+value.+} [#960](https://github.com/go-mysql-org/go-mysql/pull/960) ([walkline](https://github.com/walkline))
* [-replication:-]{+Replication:+} Support GTID tag in [-PreviousGTIDsEvent-]{+PreviousGTIDsEvent.+} [#952](https://github.com/go-mysql-org/go-mysql/pull/952) ([dveeden](https://github.com/dveeden))
* [-zeroalloc:-]{+Zeroalloc:+} don't use [-unsafe.Pointer-]{+unsafe.Pointer.+} [#959](https://github.com/go-mysql-org/go-mysql/pull/959) ([serprex](https://github.com/serprex))
* [-driver:-]{+Driver:+} allow configuration of the driver [-name-]{+name.+} [#958](https://github.com/go-mysql-org/go-mysql/pull/958) ([dveeden](https://github.com/dveeden))
* Update [-README-]{+README.+} [#950](https://github.com/go-mysql-org/go-mysql/pull/950) ([dveeden](https://github.com/dveeden))
* README: fix example for [-database/sql-]{+database/sql.+} [#955](https://github.com/go-mysql-org/go-mysql/pull/955) ([dveeden](https://github.com/dveeden))
* CI: Update Go, MySQL and Ubuntu [-versions-]{+versions.+} [#954](https://github.com/go-mysql-org/go-mysql/pull/954) ([dveeden](https://github.com/dveeden))
* [-canal,dump:-]{+Canal,dump:+} Improve [-logging-]{+logging.+} [#953](https://github.com/go-mysql-org/go-mysql/pull/953) ([dveeden](https://github.com/dveeden))

## Tag v1.10.0 (2024-11-20)
* replication,cmd: improve flavor handling [#946](https://github.com/go-mysql-org/go-mysql/pull/946) ([dveeden](https://github.com/dveeden))

Which is because:

  • Uppercase the first letter (I don't think we should as I often use the <package,...>: <description> format)
  • Add . at the end of the title
  • This still need manual changes for *: ... as title to not break formatting.

@dveeden
Copy link
Collaborator Author

dveeden commented Jan 23, 2025

And as GitHub doesn't format/colors word diffs in a useful way:
image

@dveeden dveeden merged commit e270065 into go-mysql-org:master Jan 23, 2025
15 checks passed
@dveeden dveeden changed the title Release v1.10.1 Release v1.11.0 Jan 23, 2025
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I just loop each PR number and use gh to query PR metadata to get the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants