allow packet.Conn buffer size to be adjustable #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilaverde
commented
Jun 21, 2024
| srv := CreateMockServer(t) | ||
| defer srv.Stop() | ||
|
|
||
| SetDSNOptions(map[string]DriverOption{ |
There was a problem hiding this comment.
our application is already using SetDSNOptions so we're planning on using the same technique for the BufferSize. I didn't want to add more configuration to the public README of this project because I felt that the default for most people is probably fine and therefore no need to add more configuration options.
dvilaverde
commented
Jun 21, 2024
| @@ -53,19 +53,23 @@ type Conn struct { | |||
| } | |||
|
|
|||
| func NewConn(conn net.Conn) *Conn { | |||
| return NewBufferedConn(conn, 65536) // 64kb | |||
There was a problem hiding this comment.
keeping this NewConn function for compatibility reasons. As of now just the server code and most unit tests use this. The client code will be using NewBufferedConn.
dvilaverde
commented
Jun 22, 2024
| @@ -94,6 +99,7 @@ type Dialer func(ctx context.Context, network, address string) (net.Conn, error) | |||
| func ConnectWithDialer(ctx context.Context, network, addr, user, password, dbName string, dialer Dialer, options ...Option) (*Conn, error) { | |||
| c := new(Conn) | |||
|
|
|||
| c.BufferSize = defaultBufferSize | |||
There was a problem hiding this comment.
init the new packet Conn with the 64kb buffer size
lance6716
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our usage of this library is in an application that will maintain a few thousand active MySQL connections from a single instance and we've noticed that the application is holding a lot of memory in
packet.Conn, specifically thebufio.Readerinstances are holding about 500MB of the total 800MB heap.This PR will allow our application to change the hardcoded
65536buffer size to something more reasonable for our use case (maybe4096), which should reduce our heap by at least 50%.