Support DSN without 'user:password@' #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvilaverde
commented
Jun 12, 2024
| @@ -368,6 +368,14 @@ Configuration options can be provided by the standard DSN (Data Source Name). | |||
| [user[:password]@]addr[/db[?param=X]] | |||
| ``` | |||
|
|
|||
| #### `collation` | |||
There was a problem hiding this comment.
i forgot to add this connection param in my previous commits
dvilaverde
commented
Jun 12, 2024
| @@ -285,10 +285,8 @@ func (c *Conn) writeAuthHandshake() error { | |||
| return fmt.Errorf("invalid collation name %s", collationName) | |||
| } | |||
|
|
|||
| // the MySQL protocol calls for the collation id to be sent as 1, where only the | |||
There was a problem hiding this comment.
updating this comment which was incorrect regarding the first byte of the 23 bytes of filter being used to store the right 8 bits of the collation id.
lance6716
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a DSN like this:
would incorrectly have the property
dbin theconnInfoobject set tossl=truewhen it should have been set todb.According to the README the DSN format allows for an optional
user:password@.Adding unit tests for the
ParseDSNfunction to cover those cases.