feat: handle subevents in transaction payload event #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
reviewed
Oct 7, 2023
lance6716
reviewed
Oct 9, 2023
| e := errors.Cause(err) | ||
| // if error is not ErrExcludedTable or ErrTableNotExist or ErrMissingTableMeta, stop canal | ||
| if e != ErrExcludedTable && | ||
| e != schema.ErrTableNotExist && |
There was a problem hiding this comment.
in the old code, the error may come from any return branch in handleRowsEvent, but in your change we only checked the last return. I made a quick check that the three errors of
if e != ErrExcludedTable &&
e != schema.ErrTableNotExist &&
e != schema.ErrMissingTableMeta {
seems only come from c.GetTable
There was a problem hiding this comment.
I agree with you. In this case, I think the old code means to ignore three errors: ErrExcludedTable,schema.ErrTableNotExist, schema.ErrMissingTableMeta. So we can do this just after GetTable in handleRowsEvent
lance6716
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using canal to handle MySQL 8.0 Compressed binlog, I find that it could not get any row.
Hope that we can support handle TransactionPayloadEvent in canal, not just in replication package