row_event.go: fix the set bytes value in revert order #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if no document about it, we should test |
|
should add a test @july2993 |
|
Similar bug occurs when handle |
|
will fix it later and add test |
|
@siddontang PTAL |
ghost
reviewed
Sep 17, 2018
| @@ -523,6 +523,71 @@ func (_ *testDecodeSuite) TestParseJsonDecimal(c *C) { | |||
| } | |||
| } | |||
|
|
|||
| func (_ *testDecodeSuite) TestEnum(c *C) { | |||
There was a problem hiding this comment.
Maybe we should add test that covers case length=2 in row_event.go
There was a problem hiding this comment.
😯 i make a mistake, should add more than 256 enum num but not more than 8 to test case length=2
There was a problem hiding this comment.
please add a new test later @july2993
There was a problem hiding this comment.
@siddontang add here #320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix pingcap/tidb-tools#70
according to the binlog, we should handle it in little end
i have test more when the set num is 18 (need 3 bytes), but i can't find a doc from mysql about this