Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store masterinfo data in elasticsearch #253

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

store masterinfo data in elasticsearch #253

wants to merge 5 commits into from

Conversation

yinzhigang
Copy link
Contributor

Add a new masterinfo storage: elasticsearch

@siddontang
Copy link
Collaborator

@yinzhigang

Sorry for the late response, I am very busy these days.

IMO, now if we want to support multi stores to saving master info, we can create a sub-module master and move all related codes to it. like

master.go -> master/master.go
file_masterfile.go -> master/file.go
elasticserach_masterinfo.go -> master/es.go

@siddontang
Copy link
Collaborator

friendly ping @yinzhigang

@siddontang
Copy link
Collaborator

friendly ping again @yinzhigang

@siddontang siddontang mentioned this pull request Oct 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yinzhigang @siddontang