fix: better diagnosed gRPC status code in monitor middleware #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aligns status code retrieval from error with what the gRPC server logic does: 1. status.FromError 2. status.FromContextError https://github.com/grpc/grpc-go/blob/master/server.go#L1369-L1377
|
Hey @talgendler 👋🏼 , I'd appreciate a review on this. Let me know if you have any questions. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 68.02% 77.58% +9.56%
==========================================
Files 50 40 -10
Lines 1379 1227 -152
==========================================
+ Hits 938 952 +14
+ Misses 400 238 -162
+ Partials 41 37 -4 ☔ View full report in Codecov by Sentry. |
talgendler
approved these changes
Dec 3, 2023
|
Hi @talgendler , thank you for the prompt action. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns status code retrieval from error with what the gRPC server logic does:
https://github.com/grpc/grpc-go/blob/master/server.go#L1369-L1377