messageWriter.writeString shouldn't ignore IO errors

[alser777]

func (w *messageWriter) writeString(s string) {
	n, _ := io.WriteString(w.w, s)
	w.n += int64(n)
}

Error return by io.WriteString is silently ignored.

[cryptix]

Where do you found this?

I think you mean this code from the forked gomail ? This isn't part of this codebase, if at all it was turned into newCopier() in message.go which looks fine.

[alser777]

writeto.go

[cryptix]

Looks like I was holding that totally wrong.

Sorry, you are right and I agree that it should set w.err and not ignore it.

[cryptix]

@LethalRes check the PR I just made

[ivy]

@LethalRes This should be fixed now. Thanks again @cryptix! 👍