Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

funcr: Handle nested empty groups properly #274

Merged
merged 2 commits into from
Mar 22, 2024
Merged

funcr: Handle nested empty groups properly #274

merged 2 commits into from
Mar 22, 2024

Commits on Mar 1, 2024

  1. Fix slog tests for 1.22 

    A new group-related case was added.
    @thockin
    thockin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    a6645b7 View commit details
    Browse the repository at this point in the history

  2. funcr: Handle nested empty groups properly 

    This ruins the whole idea of pre-rendering.  We simply don't know if we
have to render a group until we know the whole log record.  Not having
values at the time that `WithGroup` is called is not sufficient
information.
    @thockin
    thockin committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    376cba9 View commit details
    Browse the repository at this point in the history