Merge pull request #268 from thockin/master

Fix lint: named but unused params
go-logr · Feb 13, 2024 · 7141c7e · 7141c7e
2 parents c9b5476 + 1cc4a3c
commit 7141c7e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/example_slogr_test.go b/example_slogr_test.go
@@ -30,7 +30,7 @@ import (
 )
 
 var debugWithoutTime = &slog.HandlerOptions{
-	ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
+	ReplaceAttr: func(_ []string, a slog.Attr) slog.Attr {
 		if a.Key == "time" {
 			return slog.Attr{}
 		}

diff --git a/funcr/funcr_test.go b/funcr/funcr_test.go
@@ -840,7 +840,7 @@ func TestSanitize(t *testing.T) {
 
 func TestEnabled(t *testing.T) {
 	t.Run("default V", func(t *testing.T) {
-		log := newSink(func(prefix, args string) {}, NewFormatter(Options{}))
+		log := newSink(func(_, _ string) {}, NewFormatter(Options{}))
 		if !log.Enabled(0) {
 			t.Errorf("expected true")
 		}
@@ -849,7 +849,7 @@ func TestEnabled(t *testing.T) {
 		}
 	})
 	t.Run("V=9", func(t *testing.T) {
-		log := newSink(func(prefix, args string) {}, NewFormatter(Options{Verbosity: 9}))
+		log := newSink(func(_, _ string) {}, NewFormatter(Options{Verbosity: 9}))
 		if !log.Enabled(8) {
 			t.Errorf("expected true")
 		}

diff --git a/funcr/slogsink_test.go b/funcr/slogsink_test.go
@@ -144,7 +144,7 @@ func TestRunSlogTests(t *testing.T) {
 }
 
 func TestLogrSlogConversion(t *testing.T) {
-	f := New(func(prefix, args string) {}, Options{})
+	f := New(func(_, _ string) {}, Options{})
 	f2 := logr.FromSlogHandler(logr.ToSlogHandler(f))
 	if want, got := f, f2; got != want {
 		t.Helper()

diff --git a/logr_test.go b/logr_test.go
@@ -60,7 +60,7 @@ func TestEnabled(t *testing.T) {
 	calledEnabled := 0
 
 	sink := &testLogSink{}
-	sink.fnEnabled = func(lvl int) bool {
+	sink.fnEnabled = func(_ int) bool {
 		calledEnabled++
 		return true
 	}

diff --git a/slogr_test.go b/slogr_test.go
@@ -86,7 +86,7 @@ func TestFromSlogHandler(t *testing.T) {
 }
 
 var debugWithoutTime = &slog.HandlerOptions{
-	ReplaceAttr: func(groups []string, a slog.Attr) slog.Attr {
+	ReplaceAttr: func(_ []string, a slog.Attr) slog.Attr {
 		if a.Key == "time" {
 			return slog.Attr{}
 		}