Skip to content

refactor: simplify WhoAmI implementation using Extended API #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpuschma merged 3 commits into from
Feb 5, 2026
Merged

refactor: simplify WhoAmI implementation using Extended API #577

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a72ee0
refactor: simplify `WhoAmI` implementation using `Extended` API
cpuschma Feb 5, 2026
5a6573a
Merge branch 'master' into feature/whoami
cpuschma Feb 5, 2026
32c5460
Remove check for REsultCode in WhoAmIResult handling
cpuschma Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 4 additions & 72 deletions v3/whoami.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,88 +4,20 @@ package ldap
//
// https://tools.ietf.org/html/rfc4532

import (
"errors"
"fmt"

ber "github.com/go-asn1-ber/asn1-ber"
)

type whoAmIRequest bool

// WhoAmIResult is returned by the WhoAmI() call
type WhoAmIResult struct {
AuthzID string
}

func (r whoAmIRequest) encode() (*ber.Packet, error) {
request := ber.Encode(ber.ClassApplication, ber.TypeConstructed, ApplicationExtendedRequest, nil, "Who Am I? Extended Operation")
request.AppendChild(ber.NewString(ber.ClassContext, ber.TypePrimitive, 0, ControlTypeWhoAmI, "Extended Request Name: Who Am I? OID"))
return request, nil
}

// WhoAmI returns the authzId the server thinks we are, you may pass controls
// like a Proxied Authorization control
func (l *Conn) WhoAmI(controls []Control) (*WhoAmIResult, error) {
packet := ber.Encode(ber.ClassUniversal, ber.TypeConstructed, ber.TagSequence, nil, "LDAP Request")
packet.AppendChild(ber.NewInteger(ber.ClassUniversal, ber.TypePrimitive, ber.TagInteger, l.nextMessageID(), "MessageID"))
req := whoAmIRequest(true)
encodedWhoAmIRequest, err := req.encode()
if err != nil {
return nil, err
}
packet.AppendChild(encodedWhoAmIRequest)

if len(controls) != 0 {
packet.AppendChild(encodeControls(controls))
}

l.Debug.PrintPacket(packet)

msgCtx, err := l.sendMessage(packet)
if err != nil {
return nil, err
}
defer l.finishMessage(msgCtx)

result := &WhoAmIResult{}

l.Debug.Printf("%d: waiting for response", msgCtx.id)
packetResponse, ok := <-msgCtx.responses
if !ok {
return nil, NewError(ErrorNetwork, errors.New("ldap: response channel closed"))
}
packet, err = packetResponse.ReadPacket()
l.Debug.Printf("%d: got response %p", msgCtx.id, packet)
extendedRequest := NewExtendedRequest(ControlTypeWhoAmI, nil)
extendedRequest.Controls = controls
resp, err := l.Extended(extendedRequest)
if err != nil {
return nil, err
}

if packet == nil {
return nil, NewError(ErrorNetwork, errors.New("ldap: could not retrieve message"))
}

if l.Debug {
if err := addLDAPDescriptions(packet); err != nil {
return nil, err
}
ber.PrintPacket(packet)
}

if packet.Children[1].Tag == ApplicationExtendedResponse {
if err := GetLDAPError(packet); err != nil {
return nil, err
}
} else {
return nil, NewError(ErrorUnexpectedResponse, fmt.Errorf("Unexpected Response: %d", packet.Children[1].Tag))
}

extendedResponse := packet.Children[1]
for _, child := range extendedResponse.Children {
if child.Tag == 11 {
result.AuthzID = ber.DecodeString(child.Data.Bytes())
}
}

return result, nil
return &WhoAmIResult{AuthzID: resp.Value.Data.String()}, nil
}
Loading