fix(registry): add timeout validation #3492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
使用 Consul 做服务发现时,如果 gRPC Client 的 timeout 设置为 0,程序会报错
discovery create watcher overtime
。原因是:
timeout
传给 discovery;kratos/transport/grpc/client.go
Lines 190 to 196 in 861493a
Build
会因为timeout
为 0,立马超时,得到ErrWatcherCreateTimeout
的错误。kratos/transport/grpc/resolver/discovery/builder.go
Lines 97 to 102 in 861493a