Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix errors reported by Lint CI. #3435

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

mo3et
Copy link
Contributor

@mo3et mo3et commented Oct 10, 2024

Description (what this PR does / why we need it):

fix errors reported by Lint CI when this PR merged.

Which issue(s) this PR fixes (resolves / be part of):

This CI report need to use blank replace unused ctx. And CI config fields is deprecated. This PR is fix it.

Other special notes for the reviewers:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 10, 2024
app.go Show resolved Hide resolved
@mo3et mo3et changed the title fix: fix errors reported by Lint CI. [WIP] fix: fix errors reported by Lint CI. Oct 10, 2024
@mo3et mo3et changed the title [WIP] fix: fix errors reported by Lint CI. fix: fix errors reported by Lint CI. Oct 11, 2024
@dosubot dosubot bot added the LGTM label Oct 11, 2024
Copy link
Member

@shenqidebaozi shenqidebaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenqidebaozi shenqidebaozi merged commit 7cd86eb into go-kratos:main Oct 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants