Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware/validate): replace PGV by protovalidate-go #3084

Closed
wants to merge 8 commits into from
Closed

feat(middleware/validate): replace PGV by protovalidate-go #3084

wants to merge 8 commits into from

Conversation

perriea
Copy link
Contributor

@perriea perriea commented Nov 13, 2023

Description (what this PR does / why we need it):

  • Replace PGV by protovalidate-go on validate package,
  • Remove PGV on kratos cli

Which issue(s) this PR fixes (resolves / be part of):

#3081

WARNING It's a breaking change !

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (c7fa51d) 84.62% compared to head (e90f165) 84.11%.

❗ Current head e90f165 differs from pull request most recent head 1ff90bb. Consider uploading reports for the commit 1ff90bb to get more accurate results

Files Patch % Lines
middleware/validate/validate.go 28.57% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   84.62%   84.11%   -0.52%     
==========================================
  Files          88       88              
  Lines        3993     3997       +4     
==========================================
- Hits         3379     3362      -17     
- Misses        440      457      +17     
- Partials      174      178       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perriea perriea marked this pull request as ready for review November 20, 2023 18:38
@perriea
Copy link
Contributor Author

perriea commented Nov 20, 2023

@shenqidebaozi we have everything, but I don't know how to test validation with this new format. If you have an idea...
https://github.com/go-kratos/kratos/pull/3084/files#diff-ab47f4f86064e3934ea13b3f4611a2a223f0655e51afbeea00b989d25ecadc75R32

@perriea
Copy link
Contributor Author

perriea commented Jan 2, 2024

@shenqidebaozi Let me remind you, any opinion ?

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 3, 2024
@IfanTsai
Copy link

IfanTsai commented Mar 5, 2024

Any update for this PR?

@perriea
Copy link
Contributor Author

perriea commented Mar 5, 2024

Any update for this PR?

This change is important, but I have no answer... Sorry

@shenqidebaozi
Copy link
Member

Please fix the issue of github action line failure first

@shenqidebaozi
Copy link
Member

Also, should we treat PGV as some kind of implementation, with the standard interface in validate

@perriea
Copy link
Contributor Author

perriea commented Mar 5, 2024

Please fix the issue of github action line failure first

We have a problem on the CI, I have an error unrelated to my modifications (contrib)...

@shenqidebaozi
Copy link
Member

Your code changes contain many contrib changes. You may consider resubmitting a PR or abandoning other changes and only modifying PGV

@hartza-capital hartza-capital closed this by deleting the head repository Mar 21, 2024
@shenqidebaozi
Copy link
Member

@perriea I see that this PR has been closed. Is there any problem?

@shenqidebaozi
Copy link
Member

The current PR only needs to remove additional modifications. Also, can the validate interface be retained and PGV be used as a new implementation. What do you think?

@perriea
Copy link
Contributor Author

perriea commented Mar 25, 2024

@perriea I see that this PR has been closed. Is there any problem?

One of my colleagues accidentally deleted my fork... this action closed my PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants