-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(middleware/validate): replace PGV by protovalidate-go #3084
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3084 +/- ##
==========================================
- Coverage 84.62% 84.11% -0.52%
==========================================
Files 88 88
Lines 3993 3997 +4
==========================================
- Hits 3379 3362 -17
- Misses 440 457 +17
- Partials 174 178 +4 ☔ View full report in Codecov by Sentry. |
@shenqidebaozi we have everything, but I don't know how to test validation with this new format. If you have an idea... |
@shenqidebaozi Let me remind you, any opinion ? |
Any update for this PR? |
This change is important, but I have no answer... Sorry |
Please fix the issue of github action line failure first |
Also, should we treat PGV as some kind of implementation, with the standard interface in validate |
We have a problem on the CI, I have an error unrelated to my modifications (contrib)... |
Your code changes contain many contrib changes. You may consider resubmitting a PR or abandoning other changes and only modifying PGV |
@perriea I see that this PR has been closed. Is there any problem? |
The current PR only needs to remove additional modifications. Also, can the |
One of my colleagues accidentally deleted my fork... this action closed my PR... |
Description (what this PR does / why we need it):
validate
package,kratos
cliWhich issue(s) this PR fixes (resolves / be part of):
#3081
WARNING It's a breaking change !