Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support adding headers to before calloption header #3038

Merged

Conversation

ibrahimalbarghouthi
Copy link
Contributor

Adding capability to pass headers to generated transport http code, by allowing before to add header carrier to calloption and using it on the client side.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (421dbc7) 84.35% compared to head (9e44d7f) 84.31%.

❗ Current head 9e44d7f differs from pull request most recent head 72775ac. Consider uploading reports for the commit 72775ac to get more accurate results

Files Patch % Lines
transport/http/client.go 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3038      +/-   ##
==========================================
- Coverage   84.35%   84.31%   -0.04%     
==========================================
  Files          88       88              
  Lines        3988     3991       +3     
==========================================
+ Hits         3364     3365       +1     
- Misses        448      449       +1     
- Partials      176      177       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Cluas Cluas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cluas Cluas merged commit 1e4e37a into go-kratos:main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants