Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove non-existent test methods #2770

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

demoManito
Copy link
Member

Description (what this PR does / why we need it):

Which issue(s) this PR fixes (resolves / be part of):

Other special notes for the reviewers:

@demoManito demoManito force-pushed the chore/remove-todo-test branch from d3a666c to 3430a04 Compare April 10, 2023 07:17
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #2770 (463f5f8) into main (702f96c) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 463f5f8 differs from pull request most recent head 13954a1. Consider uploading reports for the commit 13954a1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #2770      +/-   ##
==========================================
- Coverage   84.45%   84.42%   -0.03%     
==========================================
  Files          88       88              
  Lines        3988     3988              
==========================================
- Hits         3368     3367       -1     
+ Misses        446      445       -1     
- Partials      174      176       +2     

see 3 files with indirect coverage changes

@demoManito demoManito force-pushed the chore/remove-todo-test branch from 3430a04 to 135e552 Compare June 21, 2023 07:27
@demoManito demoManito force-pushed the chore/remove-todo-test branch from 135e552 to 58e5927 Compare August 18, 2023 07:29
@demoManito demoManito force-pushed the chore/remove-todo-test branch from 58e5927 to 13954a1 Compare November 9, 2023 06:24
@demoManito demoManito changed the title chore: remove non-existent test methods test: remove non-existent test methods Nov 15, 2023
@demoManito demoManito force-pushed the chore/remove-todo-test branch from 13954a1 to ef29e10 Compare May 8, 2024 08:25
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 8, 2024
@demoManito demoManito force-pushed the chore/remove-todo-test branch from ef29e10 to 3b17fa4 Compare September 2, 2024 04:01
@demoManito
Copy link
Member Author

@shenqidebaozi PTAL

@dosubot dosubot bot added the LGTM label Sep 9, 2024
@shenqidebaozi shenqidebaozi merged commit 908e625 into go-kratos:main Sep 9, 2024
33 checks passed
@demoManito demoManito deleted the chore/remove-todo-test branch November 5, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants