Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a PUT bug, and consistently handle updates to non-winning leaf revs #921

Merged
merged 7 commits into from
Apr 3, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.29%. Comparing base (f1783a9) to head (33b15a0).

Files Patch % Lines
x/sqlite/put.go 88.23% 1 Missing and 1 partial ⚠️
x/sqlite/putattachment.go 80.00% 1 Missing and 1 partial ⚠️
x/sqlite/util.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
- Coverage   64.30%   64.29%   -0.02%     
==========================================
  Files         297      297              
  Lines       19795    19782      -13     
==========================================
- Hits        12730    12719      -11     
+ Misses       6462     6460       -2     
  Partials      603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit a773c05 into master Apr 3, 2024
3 checks passed
@flimzy flimzy deleted the putFailure branch April 3, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant