Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish Get() #887

Merged
merged 6 commits into from
Feb 18, 2024
Merged

Finish Get() #887

merged 6 commits into from
Feb 18, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Feb 17, 2024

Except for:

  • attachments (need to add support to Put first)
  • open_revs -- handled by the OpenRevs method instead

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1225c6a) 63.50% compared to head (e2643fb) 63.63%.

Files Patch % Lines
x/sqlite/db.go 98.55% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
+ Coverage   63.50%   63.63%   +0.13%     
==========================================
  Files         287      287              
  Lines       19153    19223      +70     
==========================================
+ Hits        12163    12233      +70     
- Misses       6416     6417       +1     
+ Partials      574      573       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 3f875c1 into master Feb 18, 2024
3 checks passed
@flimzy flimzy deleted the sqliteLatest branch February 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant