x/mango: Fix evaluation of $exists: false always failing
#1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! I see one small improvement that needs to be made, but I'll do that in a follow-up PR, as I have the relevant code already elsewhere in the repo. I'll just move it into place, then cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the evaluation of
$exists: falseby makingfieldNode.Match()always pass the value to the condition, even if it is not found in the map.It also makes it possible to do subfield lookups using dot notation (e.g.
foo.bar.baz) as mentioned in the CouchDB documentation.This PR fixes #1043.