Improve error message for invalid private keys#195
Merged
jsha merged 1 commit intogo-jose:mainfrom Jul 17, 2025
Merged
Conversation
Collaborator
|
Thanks for the PR! The same error exists in edPrivateKey(). ecPrivateKey(), ecPublicKey, and rsaPublicKey also doesn't print which fields are missing, just that one is missing. Would you like to make all of these use the same pattern here? I'm happy to do it myself if you don't want to, so just let me know. |
Contributor
Author
|
@mcpherrinm yep, i will fix it |
ProjectMutilation
force-pushed
the
fix-logic-error
branch
from
dd7259a to
d53b975
Compare
Collaborator
|
Thanks! One more minor problem, can you |
The switch statement is exited subsequent to the first condition that evaluates to true, yet it is evident from the context that the intention was to cover all possibilities. Found by PostgresPro Fixes: 98e5a54 ("Print all missing fields at once") Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
ProjectMutilation
force-pushed
the
fix-logic-error
branch
from
d53b975 to
a2d1bce
Compare
Contributor
Author
My bad, fixed |
mcpherrinm
approved these changes
Jul 4, 2025
mcpherrinm
changed the title
jsha
approved these changes
Jul 17, 2025
This was referenced Apr 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The switch statement is exited subsequent to the first condition that evaluates to true, yet it is evident from the context that the intention was to cover all possibilities.
Found by PostgresPro
Fixes: 98e5a54 ("Print all missing fields at once")