Support middleware compression with Zlib, LZW, Brotli, and Zstd encoders #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request provides new Encoders for the Goyave compress middleware using the following algorithms: - Zlib (deflate) - LZW - Brotli - Zstd Tests and comments are included.
Pull Request Test Coverage Report for Build 10181781816Details
💛 - Coveralls |
System-Glitch
requested changes
Jul 30, 2024
ccoVeille
reviewed
Jul 30, 2024
|
Thanks @System-Glitch @ccoVeille for your reviews! I think I have incorporated everything. Tests appears to be failing on /websocket, but I don't think these code changes are related. Please let me know if anything else is needed. |
It's the db timeout plugin. It happens sometimes when the runner is a bit too busy. I'm not sure how I could make this test more consistent. |
|
Merged! Thank you very much. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s): #197, #198, #199, #200
This pull request provides new Encoders for the Goyave compress middleware using the following algorithms:
Tests and comments are included