Issue with quotes on unquoted alias name #826
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your user case and expected results
Testing with gorm-oracle
When the alias name is provided unquoted, the alias name used when generating the query should be unquoted as well.
For the below statement,
DB.Table("users u").Where("u.\"name\" = ?", "Bob").First(&result);
the generated query is:
SELECT * FROM users u WHERE u."name" = "Bob" AND "u"."deleted_at" IS NULL ORDER BY "u"."id" LIMIT 1
it should be:
SELECT * FROM users u WHERE u."name" = "Bob" AND u."deleted_at" IS NULL ORDER BY u."id" LIMIT 1
as oracle handles the quoted and unquoted indentifiers as separare entity.