fixed memory leak in func (stmt *Statement) ParseWithSpecialTableName#7420
Closed
ManyakRus wants to merge 2 commits intogo-gorm:masterfrom
Closed
fixed memory leak in func (stmt *Statement) ParseWithSpecialTableName#7420ManyakRus wants to merge 2 commits intogo-gorm:masterfrom
ManyakRus wants to merge 2 commits intogo-gorm:masterfrom
Conversation
|
how is this fixing memory leak ? You have commented out |
Author
|
my fix not fix memeory leak i think :-( however Gorm function WithContext() have big memory leak. |
Member
|
WithContext doesn't leak memory, maybe the ctx you created leaks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
*fixed memory leak in func (stmt Statement) ParseWithSpecialTableName
need fill nil value after using, for prevent memory leak
tables = nil
User Case Description
Gorm function WithContext() have big memory leak.
In golang version 1.2.21 my request solve all problems with memory leak.
in golang version higher gorm have another new one memory leak.