Fixed InvalidDB error when creating a new connection with PrepareStmt #4214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
I was running into an issue using Goyave with the MySQL connector, it was always returning invalid db upon connection.
Here's a snippet from the Goyave database library
This bug occurs on the call to
db.DB()
which should return a*sql.DB
object.The bug is caused by DB() trying to check if ConnPool implements the GetDBConnector interface. Goyave makes a call to gorm.Open and enables PrepareStmt. This set ConnPool to be a PrepareStmtDB. PrepareStmtDB does have a function for returning the repsonse that DB() is expecting, however it's named GetDB instead of GetDBConn so the check fails and the code returns invalid db which causes the Goyave app to panic.
I've added a wrapper around GetDB called GetDBConn so the check passes and returns the expected result. Since I'm not renaming the function, it remains backwards compatible with any code that uses the GetDB method.
User Case Description
Bug fix