Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Join function overrides clause expressions #4129

Closed
ghost opened this issue Mar 2, 2021 · 0 comments · Fixed by go-gorm/prometheus#28 or go-gorm/prometheus#29
Closed

The Join function overrides clause expressions #4129

ghost opened this issue Mar 2, 2021 · 0 comments · Fixed by go-gorm/prometheus#28 or go-gorm/prometheus#29
Assignees
@jinzhu
Labels
type:with reproduction steps with reproduction steps

Comments

@ghost
Copy link

ghost commented Mar 2, 2021

GORM Playground Link

go-gorm/playground#290

Description

The db.Join function overrides the joins implemented via db.Clauses... This should not happen... The join condition should be appended
@ghost ghost assigned jinzhu Mar 2, 2021
@github-actions github-actions bot added the type:with reproduction steps with reproduction steps label Mar 2, 2021
@jinzhu jinzhu closed this as completed in 6647552 Mar 4, 2021
jinzhu added a commit that referenced this issue Mar 5, 2021
@jinzhu
Revert "Don't override the from clauses, close #4129" close #4139
d6c2358 
This reverts commit 6647552.
jinzhu added a commit that referenced this issue Mar 5, 2021
@jinzhu
Revert "Revert "Don't override the from clauses, close #4129" close #…
a948c84 
…4139"

This reverts commit d6c2358.
This was referenced Mar 7, 2021
Closed
Merged
Merged
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this issue Mar 15, 2021
Closed
mittwillson pushed a commit to itering/gorm that referenced this issue Sep 27, 2021
@jinzhu @mittwillson
Don't override the from clauses, close go-gorm#4129
032f6ca
mittwillson pushed a commit to itering/gorm that referenced this issue Sep 27, 2021
@jinzhu @mittwillson
Revert "Don't override the from clauses, close go-gorm#4129" close go…
9b64c96 
…-gorm#4139

This reverts commit 6647552.
mittwillson pushed a commit to itering/gorm that referenced this issue Sep 27, 2021
@jinzhu @mittwillson
Revert "Revert "Don't override the from clauses, close go-gorm#4129" c…
6fbb71a 
…lose go-gorm#4139"

This reverts commit d6c2358.
cgxxv pushed a commit to cgxxv/gorm that referenced this issue Mar 25, 2022
@jinzhu
Don't override the from clauses, close go-gorm#4129
9986f6b
cgxxv pushed a commit to cgxxv/gorm that referenced this issue Mar 25, 2022
@jinzhu
Revert "Don't override the from clauses, close go-gorm#4129" close go…
1edb101 
…-gorm#4139

This reverts commit 9986f6b.
cgxxv pushed a commit to cgxxv/gorm that referenced this issue Mar 25, 2022
@jinzhu
Revert "Revert "Don't override the from clauses, close go-gorm#4129" c…
f4df92c 
…lose go-gorm#4139"

This reverts commit 1edb101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinzhu jinzhu

Labels
type:with reproduction steps with reproduction steps
Projects
None yet
Milestone
No milestone
1 participant
@jinzhu