Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model and clauses being passed even after newDB in transaction #4120

Closed
ghost opened this issue Feb 24, 2021 · 1 comment · Fixed by go-gorm/prometheus#28
Closed

Model and clauses being passed even after newDB in transaction #4120

ghost opened this issue Feb 24, 2021 · 1 comment · Fixed by go-gorm/prometheus#28
Assignees
@jinzhu
Labels
type:with reproduction steps with reproduction steps

Comments

@ghost
Copy link

ghost commented Feb 24, 2021

GORM Playground Link

go-gorm/playground#287

Description

Continuation of #4117 ... I have updated the test to check again... Even though there is a db.Session(&gorm.Session{NewDB:true}).Begin() the model and where conditions are passed to transactions...
@ghost ghost assigned jinzhu Feb 24, 2021
@ghost ghost changed the title Model being passed even after newDB in transaction Model and clauses being passed even after newDB in transaction Feb 24, 2021
@github-actions github-actions bot added the type:with reproduction steps with reproduction steps label Feb 24, 2021
@jinzhu jinzhu closed this as completed in 189547f Feb 26, 2021
@jinzhu
Copy link
Member

jinzhu commented Feb 26, 2021

Fixed, thank you for your report.

@jinzhu jinzhu reopened this Feb 26, 2021
@jinzhu jinzhu closed this as completed Feb 26, 2021
This was referenced Mar 7, 2021
Closed
Merged
mittwillson pushed a commit to itering/gorm that referenced this issue Sep 27, 2021
@jinzhu @mittwillson
Fix new session with Begin, close go-gorm#4120
b4a1e82
cgxxv pushed a commit to cgxxv/gorm that referenced this issue Mar 25, 2022
@jinzhu
Fix new session with Begin, close go-gorm#4120
214f1ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinzhu jinzhu

Labels
type:with reproduction steps with reproduction steps
Projects
None yet
Milestone
No milestone
1 participant
@jinzhu