Accept io.Reader for Attach and Embed #78
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a patch that will accept an
io.Reader
for both Attach and Embed with accompanying tests.I kept the original methods named as
Attach
and addedAttachReader
though it is up for discussion!I feel in Go the idiomatic thing would be to have
and
So that
AttachFile
is really only a convenience method. I think most people in Go would be using something io.Reader compatible?But it works for the time being and it's sufficient enough
I wanted to add an example to the example file. But since it's pointing to a gopkg.in version that couldn't be possible at the moment without breaking the test suite.
This is talked about in issue #69