Make client's identity configurable #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,9 @@ type Dialer struct { | |||
| Host string | |||
| // Port represents the port of the SMTP server. | |||
| Port int | |||
| // Identity is the host name sent to the SMTP server with the HELO command. | |||
| // The default is to use "localhost". | |||
| Identity string | |||
There was a problem hiding this comment.
Could you rename that LocalName?
That is how the variable is called in net/smtp. Also Identity can be confused with the identity variable of smtp.PlainAuth.
|
Thanks for the PR! I will merge it as soon as you fix the two points I commented. |
The net/smtp library sends "localhost" unless otherwise instructed. This commit adds a new "LocalName" field to the Dialer struct that allows users to override what gets sent with SMTP's HELO command.
|
Just pushed a new version of the code addressing all requests. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The net/smtp library sends "localhost" unless otherwise instructed. This
commit adds a new "LocalName" field to the Dialer struct that allows
users to override what gets sent with SMTP's HELO command.