Skip to content
This repository has been archived by the owner on Jun 8, 2019. It is now read-only.

Improve swagger doc #67

Merged
merged 4 commits into from
Aug 21, 2017
Merged

Improve swagger doc #67

merged 4 commits into from
Aug 21, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented Aug 8, 2017

Response type and method params are in sdk.

Needed for go-gitea/gitea#2274

@sapk sapk changed the title Improve swagger doc (Needed for #2274) Improve swagger doc Aug 8, 2017
@appleboy
Copy link
Member

LGTM

@lunny
Copy link
Member

lunny commented Aug 21, 2017

LGTM

gitea/hook.go Outdated
// HookList represents a list of API hook.
// swagger:response HookList
type HookList []*Hook

// ListOrgHooks list all the hooks of one organization
func (c *Client) ListOrgHooks(org string) ([]*Hook, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this return param is HookList ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is better to do it.

@lunny
Copy link
Member

lunny commented Aug 21, 2017

make L-G-T-M work

@lunny lunny merged commit bc243ad into go-gitea:master Aug 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants