make node_modules a order-only prerequisite #9923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package installations and our fomantic step results in changes inside node_modules which lead to make triggering that target unnecessarily. Moved all node_modules prerequisites to order-only which will make skip the timestamp check on in and eliminate useless npm calls. Changes in package-lock.json will still result in reinstallation so node_modules should stay consistent.
techknowlogick
added
the
topic/build
|
I initially had a change here that deleted node_modules on |
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Jan 21, 2020
GiteaBot
added
lgtm/need 1
|
Still seeing some unneccesary installs, not sure why $ stat package-lock.json
Access: 2020-01-21 23:48:27.770141038
Modify: 2020-01-21 23:47:11.631464000
Change: 2020-01-21 23:47:11.631478146
$ make --trace node_modules
Makefile:469: update target 'node_modules' due to: package-lock.json
$ stat package-lock.json
Access: 2020-01-21 23:49:23.633522825
Modify: 2020-01-21 23:47:11.631464000
Change: 2020-01-21 23:47:11.631478146
$ make --trace node_modules
Makefile:469: update target 'node_modules' due to: package-lock.jsonEdit: Probably some weird macOS filesystem issue. It does work on Linux: $ make --trace node_modules
make: 'node_modules' is up to date.
$ make --trace node_modules
make: 'node_modules' is up to date. |
guillep2k
approved these changes
Jan 22, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #9923 +/- ##
==========================================
- Coverage 42.27% 42.27% -0.01%
==========================================
Files 610 610
Lines 80364 80370 +6
==========================================
- Hits 33974 33973 -1
- Misses 42211 42213 +2
- Partials 4179 4184 +5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package installations and our fomantic step results in changes inside node_modules which lead to make triggering that target unnecessarily.
Moved all node_modules prerequisites to order-only which will make
makeskip the timestamp check on it and eliminate uselessnpm installcalls.Changes in package-lock.json will still result in reinstallation so node_modules should stay consistent.