Skip to content

Conversation

@sapk
Copy link
Member

@sapk sapk commented Jan 12, 2020

@sapk sapk added this to the 1.12.0 milestone Jan 12, 2020
@silverwind
Copy link
Member

I just unvendored and updated swagger-ui in #9714 so I fear this PR might be obsolete.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2020
@sapk
Copy link
Member Author

sapk commented Jan 12, 2020

@silverwind sorry I haven't see your PR.

@sapk sapk closed this Jan 12, 2020
@sapk
Copy link
Member Author

sapk commented Jan 12, 2020

@silverwind I feel after reviewing your PR that we should be better to keep this outside js build chain and stick to provided releases by swagger-ui.
I may miss one advantage to use the custom webpack build. What do you think building the swagger js add compared to using the released version ?

@silverwind
Copy link
Member

I primarily want the dependency managed by npm for easy updating.

We could use the pre-built module swagger-ui-dist and just copy it to public, but with that, we'd have to inline the initialization in the go template again which I'm not a fan of because that code will never be linted or polyfilled for our supported browsers.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/miscellaneous

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants