[Backport] [Fix] use default avatar for ghost user (fix 500 error) (#9536)

[6543]

backports #9536

• fix Deleted user's (Ghost) avater image generates error 500 #8853 (set default avatar for ghost user (dont make a 500 error))

[6543]

@techknowlogick / @lunny can you add Milestone 1.10.2 and lables?

[zeripath]

I'm not much of a fan of requerying before saving - however I guess it's the simplest thing to do and we don't want posterID to be -1.

In master we should find the code that sets this and stop that

[6543]

@zeripath I know where it come from: from loadPoster() and only API is afected becouse of the technike wich is used to update issues :(

[6543]

We have three options:

• first = simplest = in this PR (check if posterID <= 0 then dont change)
• let the system habdle -1 as ghost user (we need to change some functions)
• change how the api can update issue (for each field or specify the rows somehow)

[zeripath]

If it's only loadPoster - fix that. Then make the update method log an error, but keep the sanity saving step in as we don't want to lose data.

[6543]

@zeripath log errer as you suggest - I'll make a smal refactor on main branch wich address -1 id issue

EDIT: here: #9539

[6543]

@lafriks would be nice if you look at it - thanks

[zeripath]

As it's a backport it's fine though

[6543]

@zeripath #9539 is for upstream

[zeripath]

The IsGhost function in that differs quite a lot from this one, for example you're still going to update the posterID to -1 for anything that isn't Ghost in that. Is that still intended?

[6543]

@zeripath can we switch conversation about this to #9539 ...

[6543]

@zeripath INFO: split PR to single backport of (#9536)

because the second part differ to mouch from new PR

[6543]

@lunny this is now a "real" backport of #9536 - do you have time to approve?

[6543]

Thanks