Backport to 1.10: issue with paging in /repos/{owner}/{repo}/git/trees/{sha} api #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge other than page 1 would fail because the wrong var was used to set the entries to return
lunny
approved these changes
Dec 24, 2019
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Dec 24, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9459 to 1.10: Fixed issue with paging in /repos/{owner}/{repo}/git/trees/{sha} api. Basically, any page requested other than page 1 (where items should be returned) would fail with an index out of range error (user gets http 500) because the wrong var was being used to build the return list. Hopefully I did this right, this is the first PR I've submitted for a backport.