Skip to content

Fix wrong migration #9381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lunny merged 1 commit into from
Dec 17, 2019
Merged

Fix wrong migration #9381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion models/migrations/v112.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func removeAttachmentMissedRepo(x *xorm.Engine) error {
attachments := make([]*Attachment, 0, 50)
for {
err := x.Select("uuid").Where(builder.NotIn("release_id", builder.Select("id").From("`release`"))).
And("release_id > 0").
OrderBy("id").Limit(50, start).Find(&attachments)
if err != nil {
return err
Expand All @@ -36,6 +37,6 @@ func removeAttachmentMissedRepo(x *xorm.Engine) error {
attachments = attachments[:0]
}

_, err := x.Exec("DELETE FROM attachment WHERE release_id NOT IN (SELECT id FROM `release`)")
_, err := x.Exec("DELETE FROM attachment WHERE release_id > 0 AND release_id NOT IN (SELECT id FROM `release`)")
return err
}