Skip to content

Fix Notify Create Ref Error on tag creation #8936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2019
Merged

Fix Notify Create Ref Error on tag creation #8936

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1bda3c
Fix Notify Create Ref Error on tag creation
zeripath Nov 12, 2019
2c9e19b
Just use the provided full ref instead of BranchCommit
zeripath Nov 12, 2019
0cc4dc1
Merge branch 'master' into fix-notify-create-ref
zeripath Nov 12, 2019
31f69ae
Merge branch 'master' into fix-notify-create-ref
zeripath Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/notification/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,9 @@ func (m *webhookNotifier) NotifyCreateRef(pusher *models.User, repo *models.Repo
return
}

shaSum, err := gitRepo.GetBranchCommitID(refName)
shaSum, err := gitRepo.GetRefCommitID(refFullName)
if err != nil {
log.Error("GetBranchCommitID[%s]: %v", refFullName, err)
log.Error("GetRefCommitID[%s]: %v", refFullName, err)
return
}

Expand Down