js: Revert change to click behaviour in forceSelection #8921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling .click() in forceSelection() in blur() causes a focus loop, this needs a proper fix later but for now just revert the change.
7 tasks
zeripath
approved these changes
Nov 11, 2019
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #8921 +/- ##
=========================================
Coverage ? 41.21%
=========================================
Files ? 546
Lines ? 70573
Branches ? 0
=========================================
Hits ? 29087
Misses ? 37788
Partials ? 3698Continue to review full report at Codecov.
|
zeripath
added
the
issue/regression
jolheiser
approved these changes
Nov 11, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling .click() in forceSelection() in blur() causes a focus loop,
this needs a proper fix later but for now just revert the change.
(Hotfix for #8919)