Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for issue_milestone #878

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Unit tests for issue_milestone #878

merged 1 commit into from
Feb 9, 2017

Conversation

ethantkoenig
Copy link
Member

Move milestone functionality to models/issue_milestone.go, remove unused functions and add unit tests.

@lunny lunny added this to the 1.1.0 milestone Feb 9, 2017
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing labels Feb 9, 2017
@lunny
Copy link
Member

lunny commented Feb 9, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 9, 2017
@appleboy
Copy link
Member

appleboy commented Feb 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 9, 2017
@lunny lunny merged commit a6751ce into go-gitea:master Feb 9, 2017
@ethantkoenig ethantkoenig deleted the issue_milestone branch February 9, 2017 18:10
@strk
Copy link
Member

strk commented Apr 30, 2017

Did this affect #1271 ?

@lunny
Copy link
Member

lunny commented May 18, 2017

No

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @lunny @appleboy @strk @tboerger