Skip to content

Prevent removal of non-empty emoji panel following selection of duplicate #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Prevent removal of non-empty emoji panel following selection of duplicate #8609

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a83a7
fix emoji panel be removed bug in issue page, when the sub issue summ…
palytoxin Oct 21, 2019
19d144d
Merge branch 'master' into master
lafriks Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ function initReactionSelector(parent) {
if (resp && (resp.html || resp.empty)) {
const content = $(vm).closest('.content');
let react = content.find('.segment.reactions');
if (react.length > 0) {
if (!resp.empty && react.length > 0) {
react.remove();
}
if (!resp.empty) {
Expand Down