Skip to content

Add missed close in ServeBlobLFS #8527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Add missed close in ServeBlobLFS #8527

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8216612
Add missed close in ServeBlobLFS
zeripath Oct 15, 2019
ba30de4
Merge branch 'master' into fix-8273-redux-more-closers
techknowlogick Oct 15, 2019
6b1441f
Merge branch 'master' into fix-8273-redux-more-closers
lunny Oct 16, 2019
91bfa7c
Merge branch 'master' into fix-8273-redux-more-closers
techknowlogick Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions routers/repo/download.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ func ServeBlobOrLFS(ctx *context.Context, blob *git.Blob) error {
if err != nil {
return err
}
defer func() {
if err = lfsDataRc.Close(); err != nil {
log.Error("ServeBlobOrLFS: Close: %v", err)
}
}()
return ServeData(ctx, ctx.Repo.TreePath, lfsDataRc)
}

Expand Down