Skip to content

Conversation

@guillep2k
Copy link
Member

@guillep2k guillep2k commented Sep 2, 2019

This first comment is outdated. Please start reading from this comment.

This is a build I made from master by using the following before commiting:

export GOPROXY=https://goproxy.cn
go clean -i -r -cache -testcache -modcache
rm -rf vendor/
make vendor
git commit ....
git push ...

@guillep2k
Copy link
Member Author

I've confirmed the packages are retrieved from the correct proxy:

...
go: downloading github.com/flynn/go-shlex v0.0.0-20150515145356-3f9db97f8568
go: downloading github.com/cznic/strutil v0.0.0-20181122101858-275e90344537
go: extracting github.com/edsrzf/mmap-go v1.0.0
go: downloading github.com/kr/pretty v0.1.0
go: extracting github.com/BurntSushi/toml v0.3.1
go: downloading github.com/hpcloud/tail v1.0.0
go: extracting gopkg.in/stretchr/testify.v1 v1.2.2
go: extracting gopkg.in/asn1-ber.v1 v1.0.0-20150924051756-4e86f4367175
go: extracting github.com/tecbot/gorocksdb v0.0.0-20181010114359-8752a9433481
go: extracting github.com/kr/pretty v0.1.0
...

And at the same moment:

# netstat -an | fgrep :443
tcp        0      0 192.3.59.1:55158        47.246.24.227:443       TIME_WAIT
tcp        0    855 192.3.59.1:55154        47.246.24.227:443       ESTABLISHED
tcp        0      0 192.3.59.1:55144        47.246.24.227:443       TIME_WAIT
tcp        0      0 192.3.59.1:55150        47.246.24.227:443       TIME_WAIT
tcp        0      0 192.3.59.1:55142        47.246.24.227:443       TIME_WAIT

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 2, 2019
I've used:

sudo go clean -i -r -cache -testcache -modcache
make clean
make generate
make golangci-lint
make revive
make swagger-check
make swagger-validate
make test-vendor            <--- this now fails
make vendor                 <--- this now produced changes
git commit -a               <--- this commit
@guillep2k
Copy link
Member Author

OK, now it's passing:

sudo go clean -i -r -cache -testcache -modcache
make clean
make generate
make golangci-lint
make revive
make swagger-check
make swagger-validate
make test-vendor            <--- this now fails
make vendor                 <--- this now produced changes
git commit -a               <--- this commit passes CI validation

@guillep2k guillep2k changed the title Use export GOPROXY=https://goproxy.cn before build Make CI work Sep 2, 2019
@guillep2k guillep2k mentioned this pull request Sep 2, 2019
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Sep 2, 2019
@techknowlogick techknowlogick added this to the 1.10.0 milestone Sep 2, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fe1a6a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8057   +/-   ##
=========================================
  Coverage          ?   41.59%           
=========================================
  Files             ?      480           
  Lines             ?    64144           
  Branches          ?        0           
=========================================
  Hits              ?    26681           
  Misses            ?    34004           
  Partials          ?     3459

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1a6a2...8b8dd07. Read the comment docs.

@guillep2k
Copy link
Member Author

OK, this PR finally passes all tests!
I had to include unrelated #8059 to pass everything.

More good news: changes included in this go.mod are good and will not be reverted by a make vendor, even after clearing the go cache or using a proxy different from https://goproxy.cn.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 2, 2019
@techknowlogick techknowlogick merged commit 765be70 into go-gitea:master Sep 2, 2019
@guillep2k guillep2k deleted the fix-libs branch September 5, 2019 23:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants