Skip to content

Fix upload file type check #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 17, 2019
Merged

Fix upload file type check #7890

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6776ead
fix upload file type check
lunny Aug 16, 2019
e5a92d3
make the function simple and added tests
lunny Aug 16, 2019
a04b636
Merge branch 'master' into lunny/fix_upload_type_check
zeripath Aug 16, 2019
8d1d705
Merge branch 'master' into lunny/fix_upload_type_check
lunny Aug 17, 2019
2259199
Merge branch 'master' into lunny/fix_upload_type_check
zeripath Aug 17, 2019
152de76
Update comment as per @silverwind
zeripath Aug 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/upload/filetype.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ func VerifyAllowedContentType(buf []byte, allowedTypes []string) error {
allowed := false
for _, t := range allowedTypes {
t := strings.Trim(t, " ")
if t == "*/*" || t == fileType {

if t == "*/*" || t == fileType ||
// allowed text/plain; charset=utf-8
strings.HasPrefix(fileType, t+";") {
allowed = true
break
}
Expand Down