Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local runs of ssh-requiring integration tests #7855

Merged
merged 3 commits into from
Aug 14, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 14, 2019

The current ssh requiring tests will not run on my local machine due to the missing IdentitiesOnly option. This PR adds this required option to make it possible.

I have set this as backport because it's very small and self-contained and without it fixing bugs on the 1.9 branch is more difficult but not impossible so it might not need to be backported.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 14, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 14, 2019
@codecov-io
Copy link

codecov-io commented Aug 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cbe3078). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7855   +/-   ##
=========================================
  Coverage          ?   41.39%           
=========================================
  Files             ?      474           
  Lines             ?    63817           
  Branches          ?        0           
=========================================
  Hits              ?    26416           
  Misses            ?    33960           
  Partials          ?     3441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe3078...e2e5abd. Read the comment docs.

@zeripath zeripath merged commit 176ba79 into go-gitea:master Aug 14, 2019
@zeripath zeripath deleted the fix-local-run-ssh-requiring-tests branch August 14, 2019 11:19
@lunny lunny added the backport/done All backports for this PR have been created label Aug 19, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants