Handle ErrUserProhibitLogin in http git (#7586, #7591) #7590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After reviewing #7586 (comment). I think we should send and 403 and not a 401 response in this case. |
GiteaBot
added
the
lgtm/need 2
|
I think that would mean that the backport and master were not aligned unless we added another PR to apply that. |
|
The best would be to not merged this backport and do a new PR on master that will be backported. I can do it if you don't have time. |
|
I agree with @sapk that master should be fixed first |
|
Now includes backport of #7591 |
zeripath
changed the title
lafriks
approved these changes
Jul 23, 2019
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Jul 23, 2019
GiteaBot
added
lgtm/done
|
Thanks @zeripath for your reactivity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #7586 & #7591
Fix #7558