Skip to content

Fix empty commits now showing in repo overview #7521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 22, 2019
Merged

Fix empty commits now showing in repo overview #7521

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2ce534
Fix empty commits now showing in repo overview
silverwind Jul 21, 2019
5206225
add test
silverwind Jul 21, 2019
3fcae07
make fmt
silverwind Jul 21, 2019
30206c3
Merge branch 'master' into empty-commits-summary
lafriks Jul 21, 2019
2dbcc62
Merge branch 'master' into empty-commits-summary
lunny Jul 22, 2019
422adf6
Merge branch 'master' into empty-commits-summary
lafriks Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/git/commit_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ func (tes Entries) GetCommitsInfo(commit *Commit, treePath string, cache LastCom
// get it for free during the tree traversal and it's used for listing
// pages to display information about newest commit for a given path.
var treeCommit *Commit
if rev, ok := revs[""]; ok {
if treePath == "" {
treeCommit = commit
} else if rev, ok := revs[""]; ok {
treeCommit = convertCommit(rev)
}
return commitsInfo, treeCommit, nil
Expand Down