Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/serv: actually exit after fatal errors #7458

Merged
merged 1 commit into from
Jul 13, 2019
Merged

cmd/serv: actually exit after fatal errors #7458

merged 1 commit into from
Jul 13, 2019

Commits on Jul 13, 2019

  1. cmd/serv: actually exit after fatal errors 

    Regression in 356854f, where
a log.Fatal call was removed. log.Fatal calls os.Exit(1) as intended,
but without it the fail() function returns normally and execution
continues past the fatal error, causing a panic.

This is visible as a go panic log and stack trace returned to the SSH
client, which is not only ugly, it leaks server and build system
information.

Fix by removing the stray return statement so that the fail() function
always calls os.Exit(1).

Fixes: go-gitea#7457
Signed-off-by: Allen Wild <[email protected]>
    @aswild
    aswild committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    41563cf View commit details
    Browse the repository at this point in the history