Change createRepository to call PrepareWebhooks without xorm session

[davidsvantesson]

Changes the call in createRepository from prepareWebhooks to PrepareWebhooks, without the xorm session as argument. This is the same call as used in for example DeleteRepository.
I have tested this against issue #7404 and it should be solved with this fix.

[codecov-io]

Codecov Report

Merging #7447 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #7447      +/-   ##
==========================================
- Coverage    41.2%   41.19%   -0.01%     
==========================================
  Files         469      469              
  Lines       63557    63557              
==========================================
- Hits        26190    26185       -5     
- Misses      33946    33950       +4     
- Partials     3421     3422       +1

Impacted Files	Coverage Δ
models/repo.go	48.6% <0%> (ø)	⬆️
modules/log/event.go	64.61% <0%> (-1.03%)	⬇️
models/issue.go	48.74% <0%> (-0.24%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0018d56...2051e8e. Read the comment docs.

[lunny]

This is for avoiding multiple database connections since sqlite may lock.

[davidsvantesson]

The problem here is that the commit to sql database (of the hook_task) has to be done before the webhook is added to the queue. Otherwise the webhook might not be delivered (DeliverHooks in webhook.go read nothing from sql).

If it is a problem to have multiple sql sessions at the same time, a larger change than what I have proposed would be needed. Maybe the PrepareWebhooks can move to the end of createRepository (as for delete repo) after closing sql session. However createRepository is also used by ForkRepository so it is not that easy.

[lunny]

Yes, this is the bug, but your change will introduce another problem. I think we have to move go HookQueue.Add(repo.ID) outside the database transaction.

[davidsvantesson]

Database session end in ForkRepository and CreateRepository. Drawback to move HookQueue.Add there is it will duplicate the call and maybe will make code somewhat less intuitive to follow. Not sure if there is some smarter way to refactor the code, or maybe that is acceptable solution?

[davidsvantesson]

I close this PR as it wasn't a satisfactory solution for the issue.

[zeripath]

Thanks for your time and contribution. (Also thanks for closing this PR once it was no longer necessary)