Move serv hook functionality & drop GitLogger #6993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6993 +/- ##
==========================================
- Coverage 41.84% 41.56% -0.28%
==========================================
Files 443 446 +3
Lines 60158 60770 +612
==========================================
+ Hits 25176 25262 +86
- Misses 31692 32223 +531
+ Partials 3290 3285 -5
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
added
the
type/refactoring
lunny
requested changes
May 20, 2019
|
The change is so big and I think we need |
|
We already do have some basic SSH tests:
These changes were broken out as #7086 - and have been merged separately - thus showing that this PR does not change the semantics of serv/hook |
Merged
|
This also fixes a bug whereby on SSH you can push to archived repositories. |
lunny
requested changes
May 21, 2019
7 tasks
* Ensure that the lfs files are created with a different prefix * Reduce the replication in git_test.go * Remove unnecessary "/"
lunny
requested changes
May 30, 2019
lunny
approved these changes
Jun 1, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jun 1, 2019
GiteaBot
added
lgtm/done
This was referenced Jun 16, 2019
Merged
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* Move hook functionality internally * Internalise serv logic * Remove old internal paths * finally remove the gitlogger * Disallow push on archived repositories * fix lint error * Update modules/private/key.go * Update routers/private/hook.go * Update routers/private/hook.go * Update routers/private/hook.go * Updated routers/private/serv.go * Fix LFS Locks over SSH * rev-list needs to be run by the hook process * fixup * Improve git test * Ensure that the lfs files are created with a different prefix * Reduce the replication in git_test.go * slight refactor * Remove unnecessary "/" * Restore ensureAnonymousClone * Restore ensureAnonymousClone * Run rev-list on server side * Try passing in the alternative directories instead * Mark test as skipped * Improve git test * Ensure that the lfs files are created with a different prefix * Reduce the replication in git_test.go * Remove unnecessary "/"
7 tasks
|
It would be nice if, any reviewer who reviewed this ticket, could draw the attention to #8273. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves most of the functionality of serv and hook into private routers. This reduces the number of http calls performed by these actions and allows for better logging of these actions.
In doing so it is now possible to remove the GitLogger. The only place where there is a possible reduction in functionality is in the handling of failures in enable-pprof but these are likely to be rare and not sufficient reason to keep this around.
(Fixes for LFS locks on SSH were broken out as #6999 and have been merged into master.)
(Improvements to git_test were broken out as #7086 and have been merged into master.)