Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix upload attachments #6481

Merged
merged 5 commits into from
Apr 2, 2019
Merged

fix upload attachments #6481

merged 5 commits into from
Apr 2, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 1, 2019

Should fix #4721

@lunny lunny added the type/bug label Apr 1, 2019
@lunny lunny added this to the 1.9.0 milestone Apr 1, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 1, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2019
lafriks
lafriks requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new migration to call sync2 on attachmet table with new field

@codecov-io
Copy link

codecov-io commented Apr 1, 2019 •
edited
Loading

Codecov Report

Merging #6481 into master will increase coverage by <.01%.
The diff coverage is 17.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
+ Coverage   40.18%   40.18%   +<.01%     
==========================================
  Files         402      403       +1     
  Lines       54021    54037      +16     
==========================================
+ Hits        21707    21717      +10     
+ Misses      29307    29306       -1     
- Partials     3007     3014       +7
Impacted Files Coverage Δ
models/migrations/migrations.go 1.52% <ø> (ø) ⬆️
routers/api/v1/repo/release_attachment.go 0% <0%> (ø) ⬆️
models/migrations/v83.go 0% <0%> (ø)
routers/repo/attachment.go 12.24% <0%> (-0.8%) ⬇️
routers/routes/routes.go 81.84% <100%> (+0.04%) ⬆️
models/attachment.go 52.05% <100%> (+8.43%) ⬆️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8e63c...4043757. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Apr 1, 2019

@lafriks done.

@techknowlogick techknowlogick merged commit 09fb036 into go-gitea:master Apr 2, 2019
@lunny lunny deleted the lunny/fix_upload_attachement branch April 3, 2019 01:12
@chotaire
Copy link

chotaire commented Apr 7, 2019

Tested as working in Gitea Version: 1.9.0+dev-61-g7ed65a98e. Thank you.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

attachments accessible without authorization
6 participants
@lunny @codecov-io @chotaire @techknowlogick @lafriks @GiteaBot