Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install.tmpl input default value #611

Merged
merged 3 commits into from
Jan 9, 2017
Merged

Fix install.tmpl input default value #611

merged 3 commits into from
Jan 9, 2017

Conversation

vcaesar
Copy link
Contributor

@vcaesar vcaesar commented Jan 8, 2017

  • Fix install.tmpl input default value(index.js 212-215)

@lunny lunny added this to the 1.1.0 milestone Jan 8, 2017
@lunny lunny added the type/enhancement An improvement of existing functionality label Jan 8, 2017
Bwko
Bwko reviewed Jan 8, 2017
View reviewed changes
public/js/index.js
@@ -209,6 +209,10 @@ function initInstall() {
return;
}

$('#db_host').val("127.0.0.1:3306");
$('#db_user').val("root");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe gitea as default user is a better choice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the default user for the database is root,I think root is a better choice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only true for MySQL/MariaDB not for PostgreSQL & MSSQL. Besides that I don't think that we should encourage users to use a root account "just because it's there".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see,"just because it's there" is not good and PostgreSQL & MSSQL is other,I updated.

@tboerger
Copy link
Member

tboerger commented Jan 8, 2017

I think there was already a pr that resolves that

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 8, 2017
@vcaesar
Copy link
Contributor Author

vcaesar commented Jan 8, 2017

@tboerger Because of format index.js,I resubmit.

@Bwko
Copy link
Member

Bwko commented Jan 8, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 8, 2017
@lunny
Copy link
Member

lunny commented Jan 9, 2017

Default value has been added via #455

@vcaesar
Copy link
Contributor Author

vcaesar commented Jan 9, 2017

@lunny This is not the same problem.

@lunny
Copy link
Member

lunny commented Jan 9, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2017
@lunny lunny merged commit 19570f2 into go-gitea:master Jan 9, 2017
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bwko Bwko Bwko left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vcaesar @tboerger @Bwko @lunny